-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Serializer] Deprecate AdvancedNameConverterInterface
#20273
base: 7.2
Are you sure you want to change the base?
Conversation
IMO yes, you should delete that note block. |
…ncedNameConverterInterface`` deprecated block
I've also deleted the Why do I need to update the example I may have not understood the changes that could occur with your PR, could you explain? |
It is because the public function normalize(string $propertyName/* , ?string $class = null, ?string $format = null, array $context = [] */): string; It now must be used as the |
…ameConverter example
Thank you for taking the time to explain I've updated the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks @mdoutreluingne 🙂
Fix #20266
Here, I don't know if I should modify or delete the
.. note::
block, what do you think?