C++20 build fix: wrap fmt argument with fmt::runtime #444
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikoff
changed the title
aaron-skydio
approved these changes
Jul 8, 2025
Member
aaron-skydio
left a comment
aaron-skydio
left a comment
There was a problem hiding this comment.
Thanks! I'll go ahead and test. I think this is independent of supporting fmtlib 9+ which is also a thing I have in progress that I haven't merged yet...
Comment on lines
25
to
31
| template <typename... T> | ||
| inline std::string FormatFailure(const char* error, const char* func, const char* file, int line, | ||
| const char* fmt, T&&... args) { | ||
| return fmt::format("SYM_ASSERT: {}\n --> {}\n --> {}:{}\n{}\n", error, func, file, line, | ||
| fmt::format(fmt, std::forward<T>(args)...)); | ||
| return fmt::format("SYM_ASSERT: {}\n --> {}\n --> {}:{}\n{}\n", | ||
| error, func, file, line, | ||
| fmt::format(fmt::runtime(fmt), std::forward<T>(args)...)); | ||
| } |
Member
There was a problem hiding this comment.
I think instead of this, we can write:
template <typename... T>
inline std::string FormatFailure(const char* error, const char* func, const char* file, int line,
fmt::format_string<T...> fmt, T&&... args) {
return fmt::format("SYM_ASSERT: {}\n --> {}\n --> {}:{}\n{}\n", error, func, file, line,
fmt::format(fmt, std::forward<T>(args)...));
}and preserve the compile-time checking
Contributor
Author
There was a problem hiding this comment.
@aaron-skydio thanks for looking into it - I changed the FormatFailure definition according to your suggestion, everything compiles and runs well.
Clang-styled code formatting was also fixed. So there should be no other issues.
Could you approve it again?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created a simple fix to enable symforce compilation for c++20 by wrapping the runtime string into
fmt::runtime.There is one downside though: we lose compile-time format-string checking for some assert-message payloads.