Skip to content

Prepare for D v2.112#16

Merged
adamdruppe merged 5 commits into
masterfrom
dc-2.112
Feb 12, 2026
Merged

Prepare for D v2.112#16
adamdruppe merged 5 commits into
masterfrom
dc-2.112

Conversation

@kinke

@kinke kinke commented Feb 10, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@adamdruppe

Copy link
Copy Markdown
Collaborator

That doesn't look correct, AA keys are supposed to be immutable.

@kinke

kinke commented Feb 10, 2026

Copy link
Copy Markdown
Collaborator Author

string isn't immutable per se either. We index it with const(char)[], and the implicit cast isn't done with D v2.112 and the templated AA implementation anymore.

@adamdruppe

Copy link
Copy Markdown
Collaborator

Do you know if the AA impl deep copies the key? I kinda recall it didn't which is why the keys were supposed to be immutable but maybe for strings it does anyway. It still needs it for disambiguating hash collisions.

@kinke

kinke commented Feb 10, 2026

Copy link
Copy Markdown
Collaborator Author

Oh I see what you meant now - no I don't know if it deep-copies, but I'd expect it not to, without special-case for strings. Maybe the new lowering should still accept 'compatible' keys (like const(char)[] here for the string index type) for read-indexing...

@adamdruppe

Copy link
Copy Markdown
Collaborator

since we are string compatible here obviously the change itself is harmless, so we can merge, just i maintain it is a compiler regression here.

@kinke

kinke commented Feb 11, 2026

Copy link
Copy Markdown
Collaborator Author

Turns out we actually have strings already, no need for the const(char)[].

The CI problems should be fixed wrt. missing mongo tools (removed from GHA runner images); the gridfs tests fail.

@kinke

kinke commented Feb 12, 2026

Copy link
Copy Markdown
Collaborator Author

@adamdruppe: Okay to merge (and tag)?

@adamdruppe adamdruppe merged commit 16e2855 into master Feb 12, 2026
0 of 16 checks passed
@adamdruppe

Copy link
Copy Markdown
Collaborator

ok tagged 0.0.15

@kinke kinke deleted the dc-2.112 branch February 12, 2026 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants