Skip to content

🐛 — Fix deprecation warnings #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ldidry merged 1 commit into from
Jul 20, 2020
Merged

🐛 — Fix deprecation warnings #2

ldidry merged 1 commit into from
Jul 20, 2020

Conversation

@ldidry
Copy link
Contributor

@ldidry ldidry commented Jun 30, 2020 •
edited
Loading

See https://rt.cpan.org/Public/Bug/Display.html?id=76857

This PR is small, but it’s only a start 🙂

Fixes #1

@ldidry ldidry requested review from dverdin, ikedas and racke June 30, 2020 08:44
@ldidry ldidry changed the base branch from master to develop June 30, 2020 08:46
@ldidry ldidry mentioned this pull request Jul 9, 2020
Merged
@ldidry
Copy link
Contributor Author

ldidry commented Jul 16, 2020

Ping @dverdin @ikedas @racke

racke
racke reviewed Jul 16, 2020
View reviewed changes
Copy link
Contributor

@racke racke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we get rid of "no warnings qw(deprecated);" or is that planned for another PR. Otherwise it looks good to me!

@ldidry
Copy link
Contributor Author

ldidry commented Jul 16, 2020

I didn’t noticed those no warnings qw(deprecated);, but it seems obvious to me that we should get rid of those, and of the unshift(@INC, 'lib'); # Should I leave this line in? that we can find in some files, like mhonarc.

I think it’s better to keep those changes for another PR since it’s not in the scope of https://rt.cpan.org/Public/Bug/Display.html?id=76857 but more of a "Let’s do some cleaning" job.

@racke
Copy link
Contributor

racke commented Jul 16, 2020

OK I agree with you.

@ldidry ldidry mentioned this pull request Jul 16, 2020
Open
@ldidry ldidry added this to the 2.6.20 milestone Jul 16, 2020
@ldidry ldidry added the bug Something isn't working label Jul 16, 2020
ikedas
ikedas approved these changes Jul 17, 2020
View reviewed changes
Copy link
Member

@ikedas ikedas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree to proposed changes. Thanks!

@ldidry
Copy link
Contributor Author

ldidry commented Jul 20, 2020

Let’s merge it to make things go forward.

@ldidry ldidry merged commit d6a1ed0 into develop Jul 20, 2020
@ldidry ldidry deleted the fix-76857 branch July 20, 2020 10:30
@ldidry ldidry mentioned this pull request Jul 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racke racke racke left review comments

@ikedas ikedas ikedas approved these changes

@dverdin dverdin Awaiting requested review from dverdin

Assignees

No one assigned

Labels

bug Something isn't working

Projects

None yet

Milestone

2.6.20 — Just fix things

Development

Successfully merging this pull request may close these issues.

Deprecation warnings in Perl 5.12/5.14

4 participants

@ldidry @racke @ikedas