[WIP] Added support for apple accelerate as BLAS/LAPACK backend.#27
Open
HasKha wants to merge 3 commits intosympiler:masterfrom
Open
[WIP] Added support for apple accelerate as BLAS/LAPACK backend.#27HasKha wants to merge 3 commits intosympiler:masterfrom
HasKha wants to merge 3 commits intosympiler:masterfrom
Conversation
Contributor
Author
|
@cheshmi did you get a chance to look into this? Thanks |
Collaborator
Not yet, I will work on it this week. Thanks |
Collaborator
|
@HasKha I can reproduce the issue. Working on it. |
Collaborator
|
I tested the following:
Not resolved the issue yet, will work on it again next week. @HasKha |
Contributor
Author
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added support for apple Accelerate. This only works on apple silicon.
Build with
cmake -DNASOQ_BLAS_BACKEND=Accelerate -DNASOQ_USE_CLAPACK=OFF .Important: This is not fully functional as it is, and I could use some help
NASOQ_Testexecutable runs and completes correctlyNASOQ_Catch2_Testshas issues, and the outcome does not appear to be deterministic. I have seen the following:nasoq::quadprogreturns 0 and x/y/z do not match. This is most often but not always.nasoq::quadprogreturns 1 and x/y/z do not match. Rare.nasoq::quadprogreturns 1 and x/y/z do match. Also rare.Note that the above issues do not exist in the current main branch, or when building in this branch with
cmake -DNASOQ_BLAS_BACKEND=OpenBLAS -DNASOQ_USE_CLAPACK=ON .