Skip to content

Add benchmark for large polynomial expansion#113

Open
VSailahari wants to merge 3 commits intosympy:masterfrom
VSailahari:add-large-expand-benchmark
Open

Add benchmark for large polynomial expansion#113
VSailahari wants to merge 3 commits intosympy:masterfrom
VSailahari:add-large-expand-benchmark

Conversation

@VSailahari
Copy link
Copy Markdown

This PR adds a benchmark for large polynomial expansion using expand((x+1)**200). This benchmark helps monitor performance regressions in polynomial manipulation routines

self.expr = (self.x + 1)**200

def time_expand(self):
self.expr.expand() No newline at end of file
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should be a newline at the end of the file.

@oscarbenjamin
Copy link
Copy Markdown
Contributor

This should be a parametrised test.

@moorepants
Copy link
Copy Markdown
Member

The PR template did not seem to work (or it was deleted).

@moorepants
Copy link
Copy Markdown
Member

I just checked and the PR template works for me. @VSailahari the PR template is required to be filled out for us to consider a PR.

@VSailahari
Copy link
Copy Markdown
Author

I just checked and the PR template works for me. @VSailahari the PR template is required to be filled out for us to consider a PR.

Thanks for the suggestion. I've modified the benchmark to be parameterized over multiple degrees to better capture scaling performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants