Conversation
|
This is good. Thanks. You'll need to also enable a flake8 check in the CI. |
Thanks for the feedback. I copied and modified the runtests.yml file from the sympy project. I modified this file to only contain the instructions for flake8 for this project. I can add the others (ruff, mypy) in the future. |
|
What is the purpose of having mypy? I don't quite see how that is relevant for a set of benchmarks. |
I think it's nice to have to catch type related bugs and to enforce some code conventions. Example error it's showing now: I understand that it can be more annoying then useful, I'll remove mypy. |
|
My preference is to remove mypy. |
|
|
||
| def time_Case3(self): | ||
| m = self.Case3**4 No newline at end of file | ||
| _ = self.Case3**4 No newline at end of file |
There was a problem hiding this comment.
| _ = self.Case3**4 | |
| _ = self.Case3**4 | |
| cse([self.y, self.G]) | ||
|
|
||
|
|
||
| S = SingletonRegistry() |
There was a problem hiding this comment.
Maybe this can be imported from sympy
|
I think that |
Thanks. |
Uh oh!
There was an error while loading. Please reload this page.