Adding code to run on Powersystem #342
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@qianbin |
Contributor
I'm sorry that i'v no privilege to merge PR. |
Author
|
@syndtr |
tgulacsi
reviewed
Jul 25, 2021
| - 1.11.x | ||
| - tip | ||
| matrix: | ||
| allow_failures: |
There was a problem hiding this comment.
Why do we allow failures?
Why test then?
tgulacsi
reviewed
Jul 25, 2021
tgulacsi
left a comment
tgulacsi
left a comment
There was a problem hiding this comment.
What does goleveldb gain by testing on ppc64le?
Has anything failed on that architecture?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
Here is my contribution to your code, its working good on powersystems.
Thanks for the code, its working good.
What do these changes do?
Added Architecture "ppc64le"
Are there changes in behavior for the user?
No