allow synnax console to run in the browser #1232
Conversation
There was a problem hiding this comment.
Awesome PR! I got it to work fine on my mac with one extra line as well (our fault for doing type assertions a long time ago, lol). I have a couple requests, as well as the comments on the PR, before we can merge:
- The code needs to be formatted and linted to our standards (which is why it is failing CI). If you have pnpm installed, you should be able to call
pnpm fix:driftandpnpm fix:consoleto fix linting issues (and callpnpm lintif they still exist), and format files by callingpnpm prettier -w drift/srcandpnpm prettier -w console/src. - Optional request and is not needed to merge since most of the app's functionality is already here, but we do have some other uses of tauri - for example, opening the file explorer (see
console/src/import/import.tsfor use cases. If you are up to it, it would be great to replace those Tauri calls with the equivalent browser APIs.
We can work on embedding it into the server later - right now the console can still be run from source code in a browser without Tauri, which is a step in the right direction.
There was a problem hiding this comment.
Instead of having this code be in drift/src/tauri/index.ts, you should make a new file that is drift/src/noop.ts that implements Runtime<S, A>.
console/src/tauriShim.ts
Outdated
| /** | ||
| * An object that looks like `Window` from `@tauri-apps/api/window`. | ||
| */ | ||
| export interface WindowLike { |
There was a problem hiding this comment.
Maybe just define this as Pick<Window, "label" | ... | "theme"> instead? Seems cleaner.
drift/src/tauri/index.ts
Outdated
| async setDecorations(value: boolean): Promise<void> { }; | ||
| async setTitle(title: string): Promise<void> { }; | ||
| async configure(): Promise<void> { | ||
| // throw new Error("Method not implemented."); |
There was a problem hiding this comment.
Should remove the commented out code and TODOs here.
There was a problem hiding this comment.
i tried it out and fixed import/export for the browser: 064dc77
i implemented it by creating ephemeral <a>/<input> elements because Mozilla seems ideologically opposed to the File System Access API (which provides window.showSaveFilePicker/window.showOpenFilePicker)
console/src/tauriShim.ts
Outdated
| /** | ||
| * An object that looks like `Window` from `@tauri-apps/api/window`. | ||
| */ | ||
| export interface WindowLike { |
drift/src/tauri/index.ts
Outdated
| async setDecorations(value: boolean): Promise<void> { }; | ||
| async setTitle(title: string): Promise<void> { }; | ||
| async configure(): Promise<void> { | ||
| // throw new Error("Method not implemented."); |
Issue Pull Request
Key Information
Description
I'm trying to run the Synnax Console on Linux. Unfortunately, the Tauri backend for linux (
libwebkit2gtk) does not supportwebgl2insideOffscreenCanvas, which breaks the renderer. The easiest workaround for me is to run the console inside Chrome. To achieve this, this PR adds web-compatible stubs for the few tauri-dependent bits of the console (kv store and drift runtime).Basic Readiness
Backwards Compatibility
Data Structures
I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:
API Changes
The following projects have backwards-compatible APIs:
Breaking Changes