Skip to content

SY-2359 - Make x/status package in all languages #1235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 46 commits into from
May 30, 2025

Conversation

pjdotson
Copy link
Contributor

@pjdotson pjdotson commented Apr 17, 2025

Issue Pull Request

Key Information

Description

Abstracts out all status packages to use the same four common statuses (info, success, warning, error) in all languages.

Basic Readiness

  • I have performed a self-review of my code.
  • I have added relevant tests to cover the changes to CI.
  • I have added needed QA steps to the release candidate template that cover these changes.
  • I have updated in-code documentation to reflect the changes.
  • I have updated user-facing documentation to reflect the changes.

Backwards Compatibility

Data Structures

I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:

  • Server
  • Console

API Changes

The following projects have backwards-compatible APIs:

  • Python Client
  • Server
  • TypeScript Client

Breaking Changes

@pjdotson pjdotson requested a review from emilbon99 April 17, 2025 22:17
@pjdotson pjdotson self-assigned this Apr 17, 2025
Copy link
Contributor

@emilbon99 emilbon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refactor status to use disabled and loading

Copy link
Contributor

@emilbon99 emilbon99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once my comments are addressed

@pjdotson pjdotson merged commit 96ce409 into rc May 30, 2025
52 of 53 checks passed
@pjdotson pjdotson deleted the sy-2359-make-statusvariant-x-package-in-all-languages branch May 30, 2025 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants