SY-2359 Make x/status package in all languages
#1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilbon99
requested changes
Apr 30, 2025
|
|
||
| import { z } from "zod"; | ||
|
|
||
| export const SUCCESS_VARIANT = "success"; |
There was a problem hiding this comment.
Assigning union value types to generic utilities like this in typescript isn't useful IMO. It's kind if like having direction="x" and direction={direction.X} inside of an Align.Space. The typescript compiler will already restrict the union types to a point where "x" is as type safe as {direction.X} and we don't introduce a whole new variable. Obv this is not the case in C++ or Go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Pull Request
Key Information
Description
Abstract out all status packages to use the same four common statuses (info, success, warning, error) in all languages.
I was going to do this in the CDC PR but realized I should practice what I preach on splitting up PRs :).
Basic Readiness
Backwards Compatibility
Data Structures
I have ensured that previous versions of stored data structures are properly migrated to new formats in the following projects:
API Changes
The following projects have backwards-compatible APIs:
Breaking Changes