SY-3673: Synnax 50.5#1941
Merged
Merged
Conversation
* [console] - checkpoint * [console] - improved UX of copy button * [pluto] - fixed capitalization in diagnostics copy * [console] - cleanup
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
sy-nico
reviewed
Feb 5, 2026
sy-nico
left a comment
sy-nico
left a comment
Contributor
There was a problem hiding this comment.
Can you move this "Build-In Functions" summary table to the top?
| } | ||
| } | ||
|
|
||
| func analyzeCompoundAssignment( |
Contributor
There was a problem hiding this comment.
Tried extracting a channel value to a variable. Could not get any of the compound operators to work. Is this expected behavior?
ERROR [valve_toggle]: [unknown] analysis failed for arc e2379646-d005-495e-8a9b-91e0e8266e12: 17:8 error: compound assignment not supported on channels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue Pull Request
Linear Issue
SY-3673
Description
Basic Readiness
Greptile Overview
Greptile Summary
This PR contains bug fixes, UI improvements, and refactoring across multiple components of the Synnax system. The changes include:
Critical Bug Fixes:
xerrors::Error::matches()when the pattern is longer than the error type (x/cpp/xerrors/errors.h:92)ReadChannelValue()when accessing empty series (arc/go/runtime/state/state.go:413)UI Enhancements:
console/src/hardware/common/task/controls/Button.Copycomponent with clipboard integration (pluto/src/button/Copy.tsx)status.toString()utility for consistent error formatting across the applicationTest Coverage:
All critical bug fixes include comprehensive test coverage demonstrating the issues and verifying the fixes.
Confidence Score: 5/5
Important Files Changed
matches()by providing end iterator tostd::mismatchReadChannelValue()by checking empty series and usinglen()instead of.Len()toString()utility for formatting status objects with details, stack traces, and timestampsSequence Diagram
sequenceDiagram participant User participant TaskControls participant StatusDisplay participant CopyButton participant ErrorHandler participant StatusUtils participant Clipboard User->>TaskControls: View task status TaskControls->>StatusDisplay: Render status with expand option StatusDisplay->>StatusUtils: Format status using toString() StatusUtils-->>StatusDisplay: Formatted error details StatusDisplay->>User: Show status with details User->>StatusDisplay: Click expand StatusDisplay->>StatusDisplay: Toggle expanded state StatusDisplay->>User: Show detailed error info User->>CopyButton: Click copy diagnostics CopyButton->>StatusUtils: Get formatted error text StatusUtils-->>CopyButton: Full diagnostic text CopyButton->>Clipboard: Write to clipboard Clipboard-->>CopyButton: Success CopyButton->>User: Show checkmark feedback User->>TaskControls: Click start/stop TaskControls->>ErrorHandler: Execute command alt Command fails ErrorHandler->>StatusUtils: Format exception StatusUtils-->>ErrorHandler: Formatted error ErrorHandler->>StatusDisplay: Display error StatusDisplay->>User: Show error with details else Command succeeds ErrorHandler->>StatusDisplay: Update status StatusDisplay->>User: Show success end