New functionalities and modules #106
Conversation
Update from Synthesio
There was a problem hiding this comment.
Thanks for this PR!
Some improvement are suggested.
Also: could you please squash you commits?
Could you use a tool to format following black formating ( to resolve issues with different formating of doc string for exemple)
And finaly, could you remove the module public_cloud_instance_shelving.py to avoid duplicated code.
| module: dedicated_server_compatible_templates | ||
| short_description: Retrieve all compatible templates for a OVH dedicated server | ||
| description: | ||
| - This module retrieves all compatibile templates for a OVH dedicated server |
| options: | ||
| service_name: | ||
| required: true | ||
| description: The service_name |
There was a problem hiding this comment.
No need for snake case here: service name
|
|
||
| EXAMPLES = r''' | ||
| - name: Retrieve all compatible templates for an OVH dedicated server | ||
| synthesio.ovh.dedicated_server_compatibile_templates: |
|
|
||
| module = AnsibleModule( | ||
| argument_spec=module_args, | ||
| supports_check_mode=True |
There was a problem hiding this comment.
There's no support for check mode in this module
| register: dedicated_templates | ||
| ''' | ||
|
|
||
| RETURN = ''' # ''' |
There was a problem hiding this comment.
We are barely not using this, but your module is returning a dictionary
| force_delete: | ||
| required: false | ||
| description: | ||
| - Force the instance deletion even if it is not in ACTIVE status |
There was a problem hiding this comment.
I think it's even if it is in ACTIVE status?
| DOCUMENTATION = ''' | ||
| --- | ||
| module: public_cloud_instance_manage | ||
| short_description: Start or stop a OVH public cloud instance |
There was a problem hiding this comment.
Start/Stop/Shelve/Unshelve
| options: | ||
| service_name: | ||
| required: true | ||
| description: The service_name |
| synthesio.ovh.public_cloud_instance_manage: | ||
| instance_id: "{{ instance_id }}" | ||
| service_name: "{{ service_name }}" | ||
| instance_action: stopped |
There was a problem hiding this comment.
the option for this is stop
Co-authored-by: tortuegenialez <[email protected]>
Added module public_cloud_instance_manage.py to start, stop, shelve and unshelve OVH cloud instance
Force deletion also for not active OVH Cloud Instances
New Call for Dedicated Server specification
Allows disk group selection during installation
Cloud Instance Deletion