Skip to content

Conversation

@Fry-4TF1V
Copy link

Added support for OLA. Possible to aggregate/deaggregate all interfaces at once.

Copy link
Collaborator

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR.
We made some changes since your previous PR:

  • The OVH class is handling calls and errors
  • We try to normalise f-string usage

@Fry-4TF1V Fry-4TF1V force-pushed the master branch 4 times, most recently from ab0fc96 to a1d0041 Compare January 7, 2025 21:50
@Fry-4TF1V
Copy link
Author

Hi @tortuegenialez,

I'm not an expert in Git, so tried to do my best to update files as requested. Hope it is good now.

Copy link
Collaborator

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the modifications, I'm in doubt with the indentation of 2 lignes

Copy link
Collaborator

@tortuegenialez tortuegenialez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants