feat(public cloud disk utils): Volume extend and info modules #115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tortuegenialez
suggested changes
Apr 14, 2025
| changed=True, | ||
| **result) | ||
|
|
||
| except APIError as api_error: |
There was a problem hiding this comment.
Exceptions are catched in the OVH class
| region = module.params['region'] | ||
| size = module.params['size'] | ||
| name = module.params['name'] | ||
|
|
There was a problem hiding this comment.
You should add a check_mode option before running for real
| try: | ||
| result = client.wrap_call( | ||
| "POST", | ||
| '/cloud/project/%s/volume/%s/upsize' % (service_name, volume_id), |
There was a problem hiding this comment.
Please use fstring
| result = [volume for volume in result if volume['name'] == module.params['name']][0] | ||
| module.exit_json(changed=False, **result) | ||
|
|
||
| except APIError as api_error: |
There was a problem hiding this comment.
Same here, exceptions are handled in the OVH class
|
|
||
| module = AnsibleModule( | ||
| argument_spec=module_args, | ||
| supports_check_mode=True |
There was a problem hiding this comment.
As this is only returning informations, the check mode could be set to false.
Otherwise you should add a check mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the ability to extend/resize volumes and obtain volume info