New modules for managing OVH firewall

[m-sarti]

These are two new modules to manage the OVH firewall on IP addresses, both for dedicated servers and IP failover.

• ip_firewall: Add, enable and disable the firewall to an OVH IP
• ip_firewall_rule: Add or delete a rule to a firewall

[gemini-code-assist]

Summary of Changes

Hello @m-sarti, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces two new Ansible modules designed to manage OVH firewalls associated with IP addresses. The ip_firewall module handles the creation, deletion, and enabling/disabling of the firewall itself on a specific IP, while the ip_firewall_rule module allows for adding and removing individual rules within that firewall.

Highlights

• New ip_firewall module: I've added a new module ip_firewall to manage the presence (state: present/absent) and enabled state (enabled: true/false) of an OVH firewall on a specific IP address (ip_on_firewall) within a given IP block (ip). This module interacts with the /ip/{ip}/firewall and /ip/{ip}/firewall/{ip_on_firewall} API endpoints.
• New ip_firewall_rule module: I've added a new module ip_firewall_rule to manage individual rules within an OVH firewall. This module allows specifying the rule's sequence, action (permit/deny), protocol, destination_port, source, source_port, and tcp_option. It interacts with the /ip/{ip}/firewall/{ip_on_firewall}/rule API endpoint.
• Rule Idempotence Limitation: The ip_firewall_rule module currently does not support updating existing rules. If a rule with the specified sequence already exists and state: present is used, the module will explicitly fail, requiring the user to delete the rule first before creating a new one with the same sequence.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two new Ansible modules, ip_firewall and ip_firewall_rule, for managing OVH IP firewalls and their rules. The modules interact with the OVH API to create, delete, and configure firewall settings.

My review focuses on correctness and maintainability. Key areas for improvement include enhancing documentation, addressing a potential idempotency limitation in ip_firewall_rule, and refining user-facing messages.