-
Notifications
You must be signed in to change notification settings - Fork 53
INFRA-10716: Remove module and update README #128
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
INFRA-10716: Remove module and update README #128
Conversation
Summary of ChangesHello @tortuegenialez, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the project by removing an outdated Ansible module that utilized a deprecated API route. Concurrently, the documentation has been thoroughly revised to accurately reflect these changes, ensuring that users are guided towards current and supported functionalities. This update improves maintainability and provides clearer, up-to-date guidance for module usage. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request successfully removes the deprecated dedicated_server_install module and updates the README.md to reflect this change by replacing it with dedicated_server_installation. The changes are mostly good, but I've found a couple of issues in the updated README example that would prevent it from working as-is. I've left a specific comment with a suggestion to fix them. Additionally, please note that there is another example in README.md (lines 183-190) that still uses the old dedicated_server_install module. This should probably be removed or updated as well to avoid confusion.
README.md
Outdated
| operatin_system: "debian12_64" | ||
| customization: | ||
| hostname: "server01.example.net" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a couple of issues in this example that would make it fail:
- There's a typo in
operatin_system. It should beoperating_system. - The parameter
customizationshould becustomizations(plural) to match thededicated_server_installationmodule's argument specification.
| operatin_system: "debian12_64" | |
| customization: | |
| hostname: "server01.example.net" | |
| operating_system: "debian12_64" | |
| customizations: | |
| hostname: "server01.example.net" |
Remove the install module for dedicated servers that use a deprecated route.
Update README to reflect this change and update list of modules.
667df27 to
a77b10a
Compare
|
Hi think I think then that #127 can also be closed |
Remove the install module for dedicated servers that use a deprecated route.
Update README to reflect this change and update list of modules.