Skip to content

Rebuild Keep module after toggling all/any#20

Open
dehall wants to merge 1 commit intomasterfrom
and_or_fix
Open

Rebuild Keep module after toggling all/any#20
dehall wants to merge 1 commit intomasterfrom
and_or_fix

Conversation

@dehall
Copy link
Copy Markdown
Collaborator

@dehall dehall commented Sep 4, 2025

Addresses #19 - Rebuilds the Keep Module after toggling the Any Of/All Of switch.

To Reproduce (from linked issue):

  • Start with the ALL OF / ANY OF toggle set to ALL OF.
  • Define some set of Keep Module Builder criteria (e.g. add some active conditions)
  • Download the Keep.json file and inspect it: default state should have states.Initial.conditional_transition[0].condition.condition_type == 'And'
  • Return to the Keep Module Builder and toggle the ALL OF / ANY OF to the ANY OF state.
  • Download the Keep.json file and inspect it: states.Initial.conditional_transition[0].condition.condition_type should now be "Or"; previously it was stuck on "And"

Note this doesn't add any debounce as suggested in the issue, that's something to tackle when we have more time

@dehall
Copy link
Copy Markdown
Collaborator Author

dehall commented Sep 4, 2025

Note: CI was already failing on master with a lot of linter errors so I'm not going to worry too much about that at the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant