Feature: support for uploading GZIP bundles of patient data#21
Open
Dtphelan1 wants to merge 1 commit intosynthetichealth:masterfrom
Open
Feature: support for uploading GZIP bundles of patient data#21Dtphelan1 wants to merge 1 commit intosynthetichealth:masterfrom
Dtphelan1 wants to merge 1 commit intosynthetichealth:masterfrom
Conversation
Collaborator
|
Hey, sorry I've been away for a few weeks plus the holiday so I'm just now actually able to look at this. At a glance it looks good and I'd be happy to merge if this is a feature you're still interested in |
Author
|
Hey there! Hope you had a good holiday! No worries on the delay - I accidentally closed this PR when I merged/deleted the branch on my fork. Still happy to see the feature get integrated. I'll reopen and respond to any feedback as needed 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Synthea Team!
We're looking at using the SPT patient viewer (and the FHIR visualizers therein) as a quick way of uploading bundles of FHIR data to a webpage to view them in a more reasonable manner than poking around a giant JSON bundle/collection of NDJSON. However, our workflows leverage a lot of gzipped data. To support that usecase, I added the
pakopackage (I thought about using the DecompressionStream API but was having issues getting that running on Node/certainly wouldn't expect it to run on package.json's recommended Node >= v14.Anyway, I wanted to pay this small PR forward incase your team was interested in adding this new package/feature into the true SPT project.
P.S. Most of the changes are just eslint rules being applied; the meat of the change occurs in
src/ui/components/PatientViewer/PatientViewer.jsx, specifically in the DropZone event handler you define.Thanks,