feat(provider_finder): Add 'prefer_one' provider finding strategy#1567
Open
andrequina wants to merge 6 commits intosynthetichealth:masterfrom
Open
feat(provider_finder): Add 'prefer_one' provider finding strategy#1567andrequina wants to merge 6 commits intosynthetichealth:masterfrom
andrequina wants to merge 6 commits intosynthetichealth:masterfrom
Conversation
Introduces a new provider finding strategy, `ProviderFinderPreferOne`, which allows configuring Synthea to prioritize a specific provider based on their NPI.
Key changes include:
- Added `ProviderFinderPreferOne.java` implementing the new logic.
- Integrated `ProviderFinderPreferOne` into `Generator.java` to:
- Set the initial simulation state based on the preferred provider's location.
- Allow overriding patient demographics based on the preferred provider.
- Added the `prefer_one` option to the provider finding mechanism in `Provider.java`.
- Refactored provider file path handling in `Provider.java` for clarity and to support locating the preferred provider.
jawalonoski
requested changes
Apr 8, 2025
Member
jawalonoski
left a comment
jawalonoski
left a comment
There was a problem hiding this comment.
Let's talk about the expected behavior of this finder.
1. Implement caching in the getPreferredProvider method to avoid repeated lookups of the same provider. This optimization improves performance by storing the provider once found and returning the cached instance on subsequent calls with the same NPI. 2. Throw ExceptionInInitializerError in overrideDemographicsIfPreferredProvider when the provider is not found by NPI.
…der is not set. Update getPreferredNPI to check if preferred provider selection behavior is enabled before retrieving the NPI from configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduces a new provider finding strategy,
ProviderFinderPreferOne, which allows configuring Synthea to prioritize a specific provider based on their NPI.Key changes include:
ProviderFinderPreferOne.javaimplementing the new logic.ProviderFinderPreferOneintoGenerator.javato:prefer_oneoption to the provider finding mechanism inProvider.java.Provider.javafor clarity and to support locating the preferred provider.