flux balance #98
Open
flux balance #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-hellerstein
left a comment
joseph-hellerstein
left a comment
There was a problem hiding this comment.
For functions with more than a couple of lines, include a comment on what the function does. Function signatures (types of arguments + return value) should be documented. You can either using typing or a comment in the function.
| self.process_function_call(node, scope) | ||
| elif type(node.get_stmt()) == IsAssignment: | ||
| self.process_is_assignment(node, scope) | ||
| elif type(node.get_stmt()) == Assignment: |
Collaborator
Author
There was a problem hiding this comment.
Use isinstance
We should create another PR for all this type of problem, because it has been the way it is.
| elif type(node.get_stmt()) == FluxBalanceConstraints: | ||
| self.process_flux_balance(node, scope) | ||
|
|
||
| def check_parse_tree_function(self, function, scope): |
There was a problem hiding this comment.
either use typing or have a function comment that provides the type of arguments and return values (if not None).
|
We could do a separate cleanup for stuff like this. The other thing that I
do is that I fix it as I go with PR sake cover the same group of code.
On Tue, Oct 4, 2022 at 11:47 PM longxf ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In vscode-antimony/src/server/stibium/stibium/analysis.py [github.com]
<https://urldefense.com/v3/__https://github.com/sys-bio/vscode-antimony/pull/98*discussion_r987582715__;Iw!!K-Hz7m0Vt54!npH9PEDtuBMvWeg648qL9ruQX63Gi9xU_JWx0veMWdrqDnX9vft1RAleuBbJMIsBmvyrvazt3Wk8HBN3s6EAVCPw$>
:
> @@ -225,6 +231,8 @@ def check_parse_tree(self, root, scope):
self.process_is_assignment(node, scope)
elif type(node.get_stmt()) == Assignment:
Use isinstance
We should create another PR for all this type of problem, because it has
been the way it is.
—
Reply to this email directly, view it on GitHub [github.com]
<https://urldefense.com/v3/__https://github.com/sys-bio/vscode-antimony/pull/98*discussion_r987582715__;Iw!!K-Hz7m0Vt54!npH9PEDtuBMvWeg648qL9ruQX63Gi9xU_JWx0veMWdrqDnX9vft1RAleuBbJMIsBmvyrvazt3Wk8HBN3s6EAVCPw$>,
or unsubscribe [github.com]
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACVJIRJ2VXDTQDCFNLZ4GTTWBUP6LANCNFSM557SWOWA__;!!K-Hz7m0Vt54!npH9PEDtuBMvWeg648qL9ruQX63Gi9xU_JWx0veMWdrqDnX9vft1RAleuBbJMIsBmvyrvazt3Wk8HBN3s12HMvze$>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
luciansmith
reviewed
Oct 19, 2022
luciansmith
reviewed
Oct 19, 2022
luciansmith
requested changes
Oct 19, 2022
Contributor
luciansmith
left a comment
luciansmith
left a comment
There was a problem hiding this comment.
A couple small fixes, but most things look fine.
|
Lucian - thanks for your help on this PR and others as well. Joe.
On Wed, Oct 19, 2022 at 10:00 PM Lucian Smith ***@***.***> wrote:
***@***.**** requested changes on this pull request.
A couple small fixes, but most things look fine.
—
Reply to this email directly, view it on GitHub [github.com]
<https://urldefense.com/v3/__https://github.com/sys-bio/vscode-antimony/pull/98*pullrequestreview-1148127816__;Iw!!K-Hz7m0Vt54!jYHo1iT7tSykZyObi1ju9MDzd190FjbBGnrMm2CUen2DhQjyzekNstCVVAwweWIZHKpxB2I0UDHTpXo9KZJTGOQA$>,
or unsubscribe [github.com]
<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/ACVJIRNHEYEZ5MSRQHRCFHLWEBAKJANCNFSM557SWOWA__;!!K-Hz7m0Vt54!jYHo1iT7tSykZyObi1ju9MDzd190FjbBGnrMm2CUen2DhQjyzekNstCVVAwweWIZHKpxB2I0UDHTpXo9KazxAHms$>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
luciansmith
approved these changes
Oct 25, 2022
Collaborator
Author
|
Do not merge this branch yet, conflict in antimony.lark needs to be resolved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.