-
Notifications
You must be signed in to change notification settings - Fork 10
recovered the docker image #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The issue isn't the docker image. There’s an issue because the Makefile compiles with |
|
Also please rebase on top of |
Hi @tareknaser , I checked all the failure reason before: The failure should have been eliminated, because in my |
|
@777lefty Thanks for the explanation. Do you think that we can also remove the make-related files from the protected files? |
|
@777lefty Please add a reference solution as well to verify that the task is solvable |
|
@777lefty Can you please solve it as soon as possible? We need to merge this PR it by tomorrow. Thanks. |
Signed-off-by: Tarek <[email protected]>
…tation Signed-off-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
… config Signed-off-by: Tarek <[email protected]>
* add ostep processes-shell lab * fix * Update benchmarks/courselab_bench/data/cs537-projects-spring-2019/processes_shell/task.md Co-authored-by: Copilot <[email protected]> --------- Co-authored-by: Tarek Elsayed <[email protected]> Co-authored-by: Copilot <[email protected]>
* added cmu15-213 data lab * docs(courselab): add note about infrastructure restrictions Signed-off-by: Tarek <[email protected]> --------- Signed-off-by: Tarek <[email protected]> Co-authored-by: Tarek <[email protected]>
Signed-off-by: Tarek <[email protected]>
Sorry for my later reply, the original requirements of the lab states explicitly that students are only allowed to modifiy Btw, I believe all the labs are ready and comments are resolved, please review them when you're free, thx! |
|
Please move the PR to the private repo. Thanks |
Description
Checked all the modified parts when migrating evaluation infrastructures, finding out that the docker image was modified, thus causing makefile of data lab to fail. went well This PR fixed this.
Changes
Testing
Ran locally with qwen3-coder-plus
Checklist