fix: add option to use camera to upload file from edit context #1011
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyaellie
reviewed
Oct 9, 2025
| type="file" | ||
| accept="image/png,image/jpeg,image/gif,image/avif,image/webp;capture=camera" | ||
| @change="uploadImage" | ||
| /> |
There was a problem hiding this comment.
Not sure about this approach as the user might want to upload e.g. pdf or really any kind of file, i feel like maybe having a separate button for taking a picture could be good, maybe only show on mobile. Also could be good to support multi file upload
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Add the ability to add a photo with the camera from the edit context.
Which issue(s) this PR fixes:
#891 May be related.
Fixes #1010
Testing
I built and pushed this as an image at
ghcr.io/adepssimius/homebox:rootless-edit-cameraand deployed to my cluster as a test deployment. I was then able to use the camera from both the create item context and the edit item context.