Skip to content

Fix auto-zoom on iOS devices #1029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
+13 −6
Open

Fix auto-zoom on iOS devices #1029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
04c2e99
Remove text-sm from inputs
alanmoo Sep 29, 2025
dd30c8c
Update frontend/components/ui/command/CommandInput.vue
alanmoo Sep 29, 2025
b2dee32
Update frontend/components/ui/tags-input/TagsInputInput.vue
alanmoo Sep 29, 2025
da5bb43
Update frontend/components/ui/select/SelectTrigger.vue
alanmoo Sep 29, 2025
d5f996d
Respond to coderrabitai
alanmoo Sep 29, 2025
44b8282
Another coderrabbit comment
alanmoo Sep 29, 2025
218f2b0
More coderrabbit responses
alanmoo Sep 29, 2025
9882469
Fix formatting
alanmoo Sep 29, 2025
893d43c
Apply suggestion from @coderabbitai[bot]
alanmoo Sep 29, 2025
8fd0f7a
Merge branch 'main' into remove-text-sm
alanmoo Sep 29, 2025
4f7e34d
Update frontend/components/ui/input/Input.vue
alanmoo Sep 29, 2025
1e3a6ff
Correct Coderrabbit's messy suggestion that I was too trigger-happy on
alanmoo Sep 29, 2025
846a09b
Merge branch 'main' into remove-text-sm
alanmoo Oct 3, 2025
7d70ef9
Merge branch 'main' into remove-text-sm
alanmoo Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion frontend/components/ui/command/CommandInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ const forwardedProps = useForwardProps(delegatedProps)
<ComboboxInput
v-bind="{ ...forwardedProps, ...$attrs }"
auto-focus
:class="cn('flex h-11 w-full rounded-md bg-transparent py-3 text-sm outline-none placeholder:text-muted-foreground disabled:cursor-not-allowed disabled:opacity-50', props.class)"
:class="cn('flex h-11 w-full rounded-md bg-transparent py-3 text-base outline-none placeholder:text-muted-foreground disabled:cursor-not-allowed disabled:opacity-50', props.class)"
/>
</div>
</template>
2 changes: 1 addition & 1 deletion frontend/components/ui/input/Input.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
v-model="modelValue"
:class="
cn(
'flex h-10 w-full rounded-md border border-input bg-background px-3 py-2 text-sm ring-offset-background file:border-0 file:bg-transparent file:text-sm file:font-medium file:text-muted-foreground placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50',
'flex h-10 w-full rounded-md border border-input bg-background px-3 py-2 text-base ring-offset-background file:border-0 file:bg-transparent file:text-base file:font-medium file:text-muted-foreground placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50',
props.class
)
"
Expand Down
2 changes: 1 addition & 1 deletion frontend/components/ui/select/SelectTrigger.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const forwardedProps = useForwardProps(delegatedProps)
<SelectTrigger
v-bind="forwardedProps"
:class="cn(
'flex h-10 w-full items-center justify-between rounded-md border border-input bg-background px-3 py-2 text-sm ring-offset-background data-[placeholder]:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50 [&>span]:truncate text-start',
'flex h-10 w-full items-center justify-between rounded-md border border-input bg-background px-3 py-2 text-base ring-offset-background data-[placeholder]:text-muted-foreground focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50 [&>span]:truncate text-start',
props.class,
)"
>
Expand Down
9 changes: 8 additions & 1 deletion frontend/components/ui/tags-input/TagsInputInput.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,12 @@ const forwardedProps = useForwardProps(delegatedProps)
</script>

<template>
<TagsInputInput v-bind="forwardedProps" :class="cn('text-sm min-h-6 focus:outline-none flex-1 bg-transparent px-1', props.class)" />
<TagsInputInput
v-bind="forwardedProps"
:class="cn(
'min-h-6 focus:outline-none flex-1 bg-transparent px-1',
props.class,
'text-base'
Copy link
Contributor Author

@alanmoo alanmoo Sep 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is at the end because Coderrabbit suggested it in case props.class sets the font-size again.

Copy link
Collaborator

@tonyaellie tonyaellie Oct 9, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont think the text size is overwritten anywhere tagsinputinput is used and i think it should be at the start so it can be overwritten by props

)"
/>
</template>
4 changes: 2 additions & 2 deletions frontend/components/ui/textarea/Textarea.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ const modelValue = useVModel(props, 'modelValue', emits, {
</script>

<template>
<textarea v-if="!props.autosize" v-model="modelValue" :class="cn('flex min-h-20 w-full rounded-md border border-input bg-background px-3 py-2 text-sm ring-offset-background placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50', props.class)" />
<textarea v-if="!props.autosize" v-model="modelValue" :class="cn('flex min-h-20 w-full rounded-md border border-input bg-background px-3 py-2 text-base ring-offset-background placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50', props.class)" />
<div v-else :class="cn('flex w-full rounded-md border border-input', props.class)">
<textarea ref="textarea" v-model="modelValue" class="w-full min-h-20 resize-none w-full rounded-md border-input bg-background px-3 py-2 text-sm ring-offset-background placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50" />
<textarea ref="textarea" v-model="modelValue" class="w-full min-h-20 resize-none w-full rounded-md border-input bg-background px-3 py-2 text-base ring-offset-background placeholder:text-muted-foreground focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-ring focus-visible:ring-offset-2 disabled:cursor-not-allowed disabled:opacity-50" />
</div>
</template>
Loading