rm maxsend to backend and retry

maxsend retry is a hack, just increase buffer and if it fails don't retry which causes confusion on HW devices

Author: jagdeep sidhu

package.json

@@ -63,7 +63,7 @@
     "@heroicons/react": "^1.0.6",
     "@reduxjs/toolkit": "^2.8.2",
     "@sidhujag/sysweb3-core": "^1.0.27",
-    "@sidhujag/sysweb3-keyring": "^1.0.581",
+    "@sidhujag/sysweb3-keyring": "^1.0.582",
     "@sidhujag/sysweb3-network": "^1.0.106",
     "@sidhujag/sysweb3-utils": "^1.1.271",
     "@tippyjs/react": "^4.2.6",

source/pages/Send/Confirm.tsx

@@ -421,6 +421,13 @@ export const SendConfirm = () => {
                 : gasLimitCandidate;
               maxSendGasLimit = gasLimit;
 
+              // Add a conservative fixed buffer for MAX sends.
+              // Some networks can require additional intrinsic costs or see small fee variance
+              // between estimation and execution. We intentionally send slightly less than MAX.
+              // Keep this as a small *absolute* reserve (not a %), since these extra costs are
+              // typically additive rather than proportional to L2 execution gas.
+              const maxSendBufferWei = parseUnits('0.000001', 'ether'); // 0.000001 native
+
               if (isEIP1559Compatible) {
                 // EIP-1559 transaction
                 const maxFeePerGasWei = parseUnits(
@@ -430,12 +437,12 @@ export const SendConfirm = () => {
                   9
                 );
                 const maxGasFeeWei = gasLimit.mul(maxFeePerGasWei);
-                value = value.sub(maxGasFeeWei);
+                value = value.sub(maxGasFeeWei).sub(maxSendBufferWei);
               } else {
                 // Legacy transaction
                 const gasPriceWei = BigNumber.from(gasPrice);
                 const gasFeeWei = gasLimit.mul(gasPriceWei);
-                value = value.sub(gasFeeWei);
+                value = value.sub(gasFeeWei).sub(maxSendBufferWei);
               }
 
               // Ensure value doesn't go negative
@@ -455,7 +462,6 @@ export const SendConfirm = () => {
                     {
                       ...restTx,
                       to: destinationTo,
-                      isMaxSend: Boolean(basicTxValues.isMax),
                       value: value.toHexString(), // Convert to hex string to avoid out-of-safe-range error
                       gasPrice: BigNumber.from(gasPrice).toHexString(), // Use BigNumber for precision
                       gasLimit: (
@@ -510,7 +516,6 @@ export const SendConfirm = () => {
                 {
                   ...restTx,
                   to: destinationTo,
-                  isMaxSend: Boolean(basicTxValues.isMax),
                   value: value.toHexString(), // Convert to hex string to avoid out-of-safe-range error
                   maxPriorityFeePerGas: parseUnits(
                     Boolean(
@@ -547,84 +552,6 @@ export const SendConfirm = () => {
 
             return;
           } catch (error: any) {
-            // For MAX sends, if we get insufficient funds error, retry with a buffer
-            // This can happen due to gas price fluctuations between estimation and execution
-            if (
-              basicTxValues.isMax &&
-              error.message?.includes('insufficient funds')
-            ) {
-              const buffer = BigNumber.from('100000');
-              const reducedValue = value.sub(buffer);
-
-              if (reducedValue.gt(0)) {
-                const retryTxObject = {
-                  ...restTx,
-                  to: destinationTo,
-                  // This retry intentionally sends slightly less than MAX to add a buffer.
-                  // Do NOT mark as isMaxSend, otherwise sysweb3 will recompute the value
-                  // and remove this buffer.
-                  isMaxSend: false,
-                  value: reducedValue.toHexString(), // Convert to hex string to avoid out-of-safe-range error
-                  maxPriorityFeePerGas: parseUnits(
-                    Boolean(
-                      customFee.isCustom && customFee.maxPriorityFeePerGas > 0
-                    )
-                      ? safeToFixed(customFee.maxPriorityFeePerGas)
-                      : safeToFixed(fee.maxPriorityFeePerGas),
-                    9
-                  ),
-                  maxFeePerGas: parseUnits(
-                    String(
-                      Boolean(customFee.isCustom && customFee.maxFeePerGas > 0)
-                        ? safeToFixed(customFee.maxFeePerGas)
-                        : safeToFixed(fee.maxFeePerGas)
-                    ),
-                    9
-                  ),
-                  gasLimit:
-                    maxSendGasLimit ||
-                    BigNumber.from(
-                      validateCustomGasLimit
-                        ? customFee.gasLimit
-                        : fee.gasLimit || basicTxValues.defaultGasLimit || 42000
-                    ),
-                };
-
-                try {
-                  // Use atomic wrapper for retry
-                  await controllerEmitter(
-                    ['wallet', 'sendAndSaveEthTransaction'],
-                    [retryTxObject, !isEIP1559Compatible],
-                    activeAccount.isTrezorWallet || activeAccount.isLedgerWallet
-                      ? 300000 // 5 minutes timeout for hardware wallet operations
-                      : 10000 // Default 10 seconds for regular wallets
-                  );
-
-                  setConfirmed(true);
-                  setLoading(false);
-                  return; // Exit early on success
-                } catch (retryError) {
-                  // If retry also fails, handle with specific error messages
-                  const wasHandledSpecifically = handleTransactionError(
-                    retryError,
-                    alert,
-                    t,
-                    activeAccount,
-                    activeNetwork,
-                    basicTxValues
-                  );
-
-                  if (!wasHandledSpecifically) {
-                    logError('error ETH retry', 'Transaction', retryError);
-                    alert.error(t('send.cantCompleteTxs'));
-                  }
-
-                  setLoading(false);
-                  return;
-                }
-              }
-            }
-
             // Handle specific errors (blacklist, cancellation, etc.) with detailed messages
             const wasHandledSpecifically = handleTransactionError(
               error,

yarn.lock

@@ -2629,10 +2629,10 @@
   resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-core/-/sysweb3-core-1.0.27.tgz#b7dd7d065c1845519e91ac470540ab94721eb33b"
   integrity sha512-aeUJpk+DiziPJbD6HFnfixKZj0T4HYStshjk6+adziftLwamNc3MIp+MtIVZwtzvNpbzIXwAnuJM/QXQsc01NQ==
 
-"@sidhujag/sysweb3-keyring@^1.0.581":
-  version "1.0.581"
-  resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-keyring/-/sysweb3-keyring-1.0.581.tgz#a75d1368aee0a89ef2f4cf1aad94f93bc792309a"
-  integrity sha512-FRSl2vFNbd55mOUN2eUJYtgh/Ia00hEBi3isW8MYDXNwHJwbHpLXlGlddX3iDvaDJ+B97lSja1SWfn/wSxsOGA==
+"@sidhujag/sysweb3-keyring@^1.0.582":
+  version "1.0.582"
+  resolved "https://registry.yarnpkg.com/@sidhujag/sysweb3-keyring/-/sysweb3-keyring-1.0.582.tgz#0e26113ac0c33183c2f5e2dcea13564669258912"
+  integrity sha512-LpnzHVoZtw4+6ElClXKgneeCz1A+O50RSm+MqGDOSLaBeYjqJxLzrHWq+k7aGEWnSMUH9xypeZtr5Jk7DEDVsQ==
   dependencies:
     "@bitcoinerlab/secp256k1" "^1.2.0"
     "@ethersproject/abstract-provider" "^5.8.0"