Skip to content

internal: trigger terraform-azurerm-secure job for PR#78

Merged
m-shah merged 2 commits into
mainfrom
add_sanity_workflow
Sep 8, 2025
Merged

internal: trigger terraform-azurerm-secure job for PR#78
m-shah merged 2 commits into
mainfrom
add_sanity_workflow

Conversation

@m-shah

@m-shah m-shah commented Sep 8, 2025

Copy link
Copy Markdown
Contributor

No description provided.

@m-shah m-shah requested a review from a team as a code owner September 8, 2025 16:59
@m-shah m-shah requested a review from Copilot September 8, 2025 16:59

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new GitHub Actions workflow to automatically trigger Jenkins sanity tests for the terraform-azurerm-secure project when pull requests are ready for review or approved.

  • Adds automated Jenkins job triggering for PR validation
  • Implements label-based skip mechanism for sanity tests
  • Configures workflow to run on PR ready_for_review and approved review events

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread .github/workflows/sanity-test.yaml Outdated
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

@ravinadhruve10 ravinadhruve10 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to be concerned with any resource conflict issues here?

Comment thread .github/workflows/sanity-test.yaml
@m-shah

m-shah commented Sep 8, 2025

Copy link
Copy Markdown
Contributor Author

Do we need to be concerned with any resource conflict issues here?

Concurrent runs are currently disabled at the job level and handled at the workflow level. You can find more details on this change at: https://github.com/sysdiglabs/terraform-azurerm-secure/pull/78/files#diff-913d90dc2a7ccc6324842a3d15b5d756e0787aa9befee876afR10

There's a possibility of resource conflicts if someone is manually using the same customer for Tenant onboarding. I've tried requesting a new tenant for this effort, but it has not been approved yet.

For scenarios where a job fails due to reasons outside of PR changes, the PR can be labeled with skip-sanity-test so it can be merged.

@m-shah m-shah merged commit c5954f6 into main Sep 8, 2025
2 of 3 checks passed
@m-shah m-shah deleted the add_sanity_workflow branch September 8, 2025 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants