Open
Conversation
baurmatt
requested changes
Aug 21, 2025
| disksize = var.db_disk_size | ||
| flavor = var.db_flavor | ||
| region = var.region | ||
| remote_ips = var.db_remote_ips |
Member
There was a problem hiding this comment.
Did you test this? 🤔 I think remote_ips isn't valid here with v2.
| default = "10.245.0.0/24" | ||
| } | ||
|
|
||
| variable "db_remote_ips" { |
Member
There was a problem hiding this comment.
Suggested change
| variable "db_remote_ips" { | |
| variable "allowed_cidrs" { |
| sys11dbaas = { | ||
| source = "registry.terraform.io/syseleven/sys11dbaas" | ||
| version = ">= 0.2.0" | ||
| version = ">= 0.3.0" |
Member
There was a problem hiding this comment.
Suggested change
| version = ">= 0.3.0" | |
| version = ">= 0.3.2" |
baurmatt
reviewed
Aug 21, 2025
| @@ -1,33 +0,0 @@ | |||
| terraform { | |||
Member
There was a problem hiding this comment.
Please keep it for now, its still used in templates/resources/database.md.tmpl. We will remove it when we drop the v1 resource.
Co-authored-by: Matthias Baur <baurmatt@users.noreply.github.com>
Co-authored-by: Matthias Baur <baurmatt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Terraform advanced example to use the V2 endpoints. Added nested block for private and public ip configuration