Use parameterized prepared statements in REST API for safer SQL execution

[rahim-kanji]

(same as title)

[gemini-code-assist]

Summary of Changes

Hello @rahim-kanji, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a critical security enhancement by implementing parameterized prepared statements for SQLite database interactions within the REST API. Specifically, the find_script functionality has been refactored to use these new methods, moving away from vulnerable string-based query construction. This change improves the overall robustness and security of the application against SQL injection attacks.

Highlights

• New Prepared Statement Execution Methods: Two new overloaded execute_prepared methods have been added to the SQLite3DB class, allowing for the execution of pre-compiled SQL statements.
• Enhanced SQL Security in REST API: The find_script function within the ProxySQL_RESTAPI_Server.cpp now utilizes parameterized prepared statements for its SQLite queries, significantly mitigating SQL injection risks.
• Refactored Query Execution: The direct string concatenation for SQL queries in the REST API has been replaced with a more secure and robust approach using sqlite3_stmt for binding parameters.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great step forward for security, replacing string-concatenated SQL queries with parameterized prepared statements to prevent SQL injection vulnerabilities in the REST API. The changes introduce new helper functions for executing prepared statements and refactor the find_script method to use them. My review focuses on improving resource management by using RAII, ensuring consistency with existing error handling logic, and fixing a couple of minor issues in the new implementation.

[sonarqubecloud]

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[rahim-kanji]

retest this please