ci: add libprotobuf-dev to unit-tests-asan-coverage workflow - #5685
Conversation
This workflow runs directly on the GitHub runner host (not inside one of the deb/rhel/suse-compliant docker containers whose entrypoints already install libprotobuf-dev on demand), so the dependency must be installed in the workflow itself. Without it, building with PROXYSQLGENAI=1 fails at Makefile parse time: the top-level Makefile recurses into plugins/mysqlx (PROXYSQL40 is implied by PROXYSQLGENAI), and plugins/mysqlx/Makefile's protobuf 3.x ABI guard aborts when it cannot find pkg-config metadata for protobuf. The rest of the dependency list mirrors INSTALL.md's Ubuntu section, to which libprotobuf-dev was added separately for general builds; this brings the workflow's package set in line with that.
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe CI workflow for ASAN coverage tests is updated to install Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.Comment |



Summary
CI-unit-tests-asan-coverage runs directly on the GitHub runner host
(not inside the
deb/rhel/suse-compliantdocker containers whoseentrypoints install
libprotobuf-devon demand), so the dependencymust be installed in the workflow itself.
Without it, any PR whose source builds with
PROXYSQLGENAI=1andrecurses into
plugins/mysqlxfails at Makefile parse time:This is what is currently blocking CI-unit-tests-asan-coverage on the
plugin-chassis PR (#5651):
workflow_runreads the workflow YAML fromthe default branch (v3.0), not from the PR branch, so the fix has
to live on v3.0 to take effect.
The change is purely the apt install list — no source code touched.
Adding
libprotobuf-devis a no-op on v3.0's own commits today (nomysqlx plugin yet), but lines this workflow up with
INSTALL.mdandunblocks the chassis PR's CI.
Test plan
install step succeeds and the build path on v3.0 still works).
after merge — should now find protobuf and reach the unit test
step.
Summary by CodeRabbit