Skip to content

ci: add libprotobuf-dev to unit-tests-asan-coverage workflow - #5685

Merged
renecannao merged 1 commit into
v3.0from
v3.0-ci-asan-libprotobuf-dev
Apr 30, 2026
Merged

ci: add libprotobuf-dev to unit-tests-asan-coverage workflow#5685
renecannao merged 1 commit into
v3.0from
v3.0-ci-asan-libprotobuf-dev

Conversation

@renecannao

@renecannao renecannao commented Apr 30, 2026

Copy link
Copy Markdown
Contributor

Summary

CI-unit-tests-asan-coverage runs directly on the GitHub runner host
(not inside the deb/rhel/suse-compliant docker containers whose
entrypoints install libprotobuf-dev on demand), so the dependency
must be installed in the workflow itself.

Without it, any PR whose source builds with PROXYSQLGENAI=1 and
recurses into plugins/mysqlx fails at Makefile parse time:

Makefile:47: *** libprotobuf not found via pkg-config. Install
libprotobuf-dev (3.x). ... Stop.

This is what is currently blocking CI-unit-tests-asan-coverage on the
plugin-chassis PR (#5651): workflow_run reads the workflow YAML from
the default branch (v3.0), not from the PR branch, so the fix has
to live on v3.0 to take effect.

The change is purely the apt install list — no source code touched.
Adding libprotobuf-dev is a no-op on v3.0's own commits today (no
mysqlx plugin yet), but lines this workflow up with INSTALL.md and
unblocks the chassis PR's CI.

Test plan

  • CI-unit-tests-asan-coverage on this PR is green (verifies the
    install step succeeds and the build path on v3.0 still works).
  • Re-run CI-unit-tests-asan-coverage on plugin-chassis (PR Plugin chassis ABI + mysqlx plugin baseline #5651)
    after merge — should now find protobuf and reach the unit test
    step.

Summary by CodeRabbit

  • Chores
    • Updated build infrastructure dependencies to support enhanced build verification processes.

This workflow runs directly on the GitHub runner host (not inside one
of the deb/rhel/suse-compliant docker containers whose entrypoints
already install libprotobuf-dev on demand), so the dependency must be
installed in the workflow itself.

Without it, building with PROXYSQLGENAI=1 fails at Makefile parse time:
the top-level Makefile recurses into plugins/mysqlx (PROXYSQL40 is
implied by PROXYSQLGENAI), and plugins/mysqlx/Makefile's protobuf 3.x
ABI guard aborts when it cannot find pkg-config metadata for protobuf.

The rest of the dependency list mirrors INSTALL.md's Ubuntu section,
to which libprotobuf-dev was added separately for general builds; this
brings the workflow's package set in line with that.
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@renecannao
renecannao merged commit 41c80e3 into v3.0 Apr 30, 2026
3 of 4 checks passed
@sonarqubecloud

Copy link
Copy Markdown

@coderabbitai

coderabbitai Bot commented Apr 30, 2026

Copy link
Copy Markdown

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 596da389-cdd7-4f00-b185-6871eb20cba9

📥 Commits

Reviewing files that changed from the base of the PR and between 6ef036a and 455eed8.

📒 Files selected for processing (1)
  • .github/workflows/CI-unit-tests-asan-coverage.yml

📝 Walkthrough

Walkthrough

The CI workflow for ASAN coverage tests is updated to install libprotobuf-dev as a build dependency on the runner host. A comment is added explaining that this package is required for the mysqlx plugin when PROXYSQLGENAI=1 triggers protobuf-related checks during the dependency build process.

Changes

Cohort / File(s) Summary
CI Workflow Dependency Update
.github/workflows/CI-unit-tests-asan-coverage.yml
Added libprotobuf-dev to apt package installation in the "Install build dependencies" step with an explanatory comment regarding protobuf ABI-guard checks for the mysqlx plugin.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • #5618: Directly modifies the same CI workflow by adding libprotobuf-dev dependency and documentation comment for the PROXYSQLGENAI build configuration.

Poem

🐰 A protobuf in the workflow's nest,
libprotobuf-dev puts CI to the test,
With mysqlx plugin standing tall,
The ABI guards safeguard all! ✨

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v3.0-ci-asan-libprotobuf-dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 7/8 reviews remaining, refill in 7 minutes and 30 seconds.

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant