Skip to content

Improve source command feedback #253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

EricccTaiwan
Copy link
Contributor

@EricccTaiwan EricccTaiwan commented Mar 11, 2025

Enhance the source command by providing clearer feedback to users. Now, if no source file is specified, the message explicitly suggests using source <file> for better clarity. Additionally, a message is printed when sourcing a file, improving user awareness.

Before: Ambiguous source command feedback

$ cat src.txt
new
free
quit
$./qtest
cmd> source
No source file given
cmd> source src.txt
cmd> new
l = []
cmd> free
l = NULL
cmd> quit
Freeing queue
$

After: Clear and informative source command messages

$ ./qtest
cmd> source
No source file given. Use 'source <file>'.
cmd> source src.txt
cmd> new
l = []
cmd> free
l = NULL
cmd> quit
Freeing queue
$ 

Change-Id: Ia1f5b9118ee369850ac6cc68f4e8344114c34a15

Enhance the "source" command by providing clearer feedback to users.
Now, if no source file is specified, the message explicitly suggests
using "source <file>" for better clarity.

Co-authored-by: JimmyChongz <[email protected]>
Change-Id: Icc194a5773860d1923dd274ebf471ba62a397370
@jserv jserv merged commit d096595 into sysprog21:master Mar 11, 2025
1 of 2 checks passed
@jserv
Copy link
Contributor

jserv commented Mar 11, 2025

Thank @EricccTaiwan for contributing!

@EricccTaiwan EricccTaiwan deleted the fix-do_source branch March 11, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants