Skip to content

Fix misleading comment #259

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 12, 2025
Merged

Conversation

Jordymalone
Copy link
Contributor

The previous comments incorrectly suggested that the file descriptor was not yet ready. In fact, the check (web_fd != -1) ensures that web_fd is valid and should be monitored in the read set. This commit updates the comment to clearly state that web_fd is available, providing an accurate description of the code's behavior.

Change-Id: Ib81d417a848e1cf41f289bd2abafb2de1c8a23d8

The previous comments incorrectly suggested that the file descriptor was
not yet ready. In fact, the check (web_fd != -1) ensures that web_fd is
valid and should be monitored in the read set. This commit updates the
comment to clearly state that web_fd is available, providing an accurate
description of the code's behavior.

Change-Id: Ib81d417a848e1cf41f289bd2abafb2de1c8a23d8
@jserv jserv merged commit 77d8deb into sysprog21:master Mar 12, 2025
1 of 2 checks passed
@jserv
Copy link
Contributor

jserv commented Mar 12, 2025

Thank @Jordymalone for contributing!

@Jordymalone Jordymalone deleted the fix-comment-record branch March 20, 2025 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants