Skip to content

Improve fork check in Git hooks installation #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2025
Merged

Improve fork check in Git hooks installation #268

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 14 additions & 14 deletions scripts/install-git-hooks
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,8 @@ fi
((CURRENT_STEP++))
progress "$CURRENT_STEP" "$TOTAL_STEPS"

ACCOUNT=$(git config -l | grep -w remote.origin.url | sed -e 's/^.*github.com[\/:]\(.*\)\/lab0-c.*/\1/')
ACCOUNT=$(git config --get remote.origin.url | awk -F'[:/]' '{print $(NF-1)}')
REPO_NAME=$(git config --get remote.origin.url | awk -F'[:/]' '{gsub(/\.git$/, "", $NF); print $NF}')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The homework assignment requires that the repository must always be named lab0-c. This naming convention serves as a strict identification mechanism to determine who is participating in the assignment.


CURL=$(which curl)
if [ $? -ne 0 ]; then
Expand All @@ -43,25 +44,24 @@ CURL_RES=$(${CURL} -s \
https://api.github.com/repos/${ACCOUNT}/lab0-c/actions/workflows)

TOTAL_COUNT=$(echo ${CURL_RES} | sed -e 's/.*"total_count": \([^,"]*\).*/\1/')
case ${TOTAL_COUNT} in
*"Not Found"*)
throw "Check your repository. It should be located at https://github.com/${ACCOUNT}/lab0-c"
esac
if [[ "$REPO_NAME" != "lab0-c" || "$TOTAL_COUNT" == *"Not Found"* ]]; then
throw "Check your repository. It should be located at https://github.com/${ACCOUNT}/lab0-c"
fi

# 3. Ensure this repository is frok from sysprog21/lab0-c'.
((CURRENT_STEP++))
progress "$CURRENT_STEP" "$TOTAL_STEPS"

if [[ "${ACCOUNT}" != "sysprog21" ]]; then
REPO_FORKED=$(${CURL} -s \
-H "Accept: application/vnd.github.v3+json" \
https://api.github.com/repos/${ACCOUNT}/lab0-c | grep -m 1 fork)
case ${REPO_FORKED} in
*true*)
;;
*)
throw "Your repository MUST be forked from 'sysprog21/lab0-c'."
esac
RESPONSE=$(${CURL} -s -H "Accept: application/vnd.github.v3+json" \
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should ensure the content retrieved from the curl command is not empty.

"https://api.github.com/repos/${ACCOUNT}/lab0-c")

IS_FORK=$(echo "$RESPONSE" | sed -n 's/.*"fork": \(true\|false\).*/\1/p' | head -n1)
PARENT_NAME=$(echo "$RESPONSE" | awk -F'"' '/"parent": \{/{flag=1} flag && /"full_name":/{print $4; exit}')

if [[ "$IS_FORK" != "true" || "$PARENT_NAME" != "sysprog21/lab0-c" ]]; then
throw "Your repository MUST be forked from 'sysprog21/lab0-c'."
fi
fi

# 4. Check GitHub Actions
Expand Down
Loading