Fix missing Change-Id #269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
requested changes
Mar 16, 2025
charliechiou
force-pushed
the
fix-change-id
branch
from
acfa05a to
6b24623
Compare
|
I'm not sure where I should append Close #267. It seems like I don’t have permission to close the issue. Thanks! |
No, check this: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue |
jserv
requested changes
Mar 16, 2025
The pull request 43a311d mistakenly set the trailers_by variable to DEFAULT_TRAILERS_BY, causing the change ID to disappear. Change the variable to KNOWN_TRAILERS_BY to ensure the change ID appears correctly. Co-authored-by: Cheng-Yang Chou <[email protected]> Change-Id: I4e3b4bfa06aba31bed2c26925ecfa5593a3d327b
charliechiou
force-pushed
the
fix-change-id
branch
from
6b24623 to
2bae253
Compare
|
Thank @charliechiou for contributing! Do reply the posts accordingly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous pull request 43a311d mistakenly set the
trailers_byvariable toDEFAULT_TRAILERS_BY, causing the change ID to disappear. Change the variable toKNOWN_TRAILERS_BYto ensure the change ID appears correctly.Close #267
Change-Id: I4e3b4bfa06aba31bed2c26925ecfa5593a3d327b