Fix LLVM builder leaks in T2C's cbeqz/cbnez/fuse12#723
Merged
Conversation
The else branches in cbeqz, cbnez, and fuse12 handlers create LLVMBuilderRef objects that are used to emit RetVoid but never disposed, leaking heap-allocated LLVM objects per T2C compilation. This adds LLVMDisposeBuilder() in each else branch, matching the pattern already used by the BRANCH_FUNC macro. Also add t2c_check_valid_blk() guard to cbeqz/cbnez branch conditions to prevent chaining to evicted or invalid blocks, aligning with BRANCH_FUNC and fuse12. Close #722
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The else branches in cbeqz, cbnez, and fuse12 handlers create LLVMBuilderRef objects that are used to emit RetVoid but never disposed, leaking heap-allocated LLVM objects per T2C compilation.
This adds LLVMDisposeBuilder() in each else branch, matching the pattern already used by the BRANCH_FUNC macro. Also add t2c_check_valid_blk() guard to cbeqz/cbnez branch conditions to prevent chaining to evicted or invalid blocks, aligning with BRANCH_FUNC and fuse12.
Close #722
Summary by cubic
Fixes LLVMBuilderRef leaks in T2C’s cbeqz/cbnez/fuse12 and adds a guard to avoid chaining to invalid blocks. This reduces per-compile heap growth and aligns behavior with BRANCH_FUNC.
Written for commit 7cd4602. Summary will update on new commits.