Integrate embench-iot as benchmark suite#724
Integrate embench-iot as benchmark suite#724yc199911 wants to merge 1 commit intosysprog21:masterfrom
Conversation
embench-iot provides 19 benchmarks designed for embedded systems, offering more representative coverage than the existing dhrystone. This complements the current benchmark infrastructure and enables more thorough performance evaluation of rv32emu. - Add embench-iot as a git submodule under tests/embench-iot - Add rv32emu board support (boardsupport.c/h) in the fork - Add wrapper Makefile to bridge rv32emu build system with scons - Register embench-iot in TEST_SUITES in mk/artifact.mk - Add scons to CI install dependencies - Update CI to detect changes under tests/embench-iot Note: This integration requires sysprog21 to create an official fork of embench-iot (similar to sysprog21/ansibench) and update the submodule URL accordingly before merging. Close sysprog21#28
There was a problem hiding this comment.
No issues found across 4 files
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
This approach should be avoided initially. The only valid reason to fork an existing benchmark suite is if it has not been maintained for some time. If you encounter build or runtime errors in embench-iot, please submit a pull request upstream first. |
|
Submitted two PRs to upstream embench-iot to avoid maintaining a separate fork:
While testing embench-iot with a GCC 15 toolchain (which defaults to C23), Once these are merged upstream, I will update this PR to point the |
embench-iot provides 19 benchmarks designed for embedded systems, offering more representative coverage than the existing dhrystone. This complements the current benchmark infrastructure and enables more thorough performance evaluation of rv32emu.
Note: This integration requires sysprog21 to create an official fork of embench-iot (similar to sysprog21/ansibench) and update the submodule URL accordingly before merging.
Close #28
Summary by cubic
Integrates
embench-iotas a new benchmark suite for rv32emu, adding 19 embedded-focused tests to improve coverage beyond Dhrystone. Hooks it into the build, CI, and artifact pipeline for repeatable runs.New Features
embench-iotas a git submodule under tests/embench-iot.scons.sconsand detect changes under tests/embench-iot.Migration
sysprog21/embench-iotfork and update the submodule URL before merging.Written for commit 6f1ea41. Summary will update on new commits.