Skip to content

[Improvement] SYST-512: Restyle, and rename style props on CapsuleTab#292

Open
alimnfl wants to merge 12 commits intomainfrom
improvement/restyle-and-rename-style-props-on-capsuletab
Open

[Improvement] SYST-512: Restyle, and rename style props on CapsuleTab#292
alimnfl wants to merge 12 commits intomainfrom
improvement/restyle-and-rename-style-props-on-capsuletab

Conversation

@alimnfl
Copy link
Contributor

@alimnfl alimnfl commented Mar 13, 2026

Description:
This pull request updates the styles API by adding self and contentStyle, allowing users to customize styling more effectively in the CapsuleTab component.

It also adds an onTabChange prop that provides a callback with the activeTab, based on the id field.

Source:
[Improvement] SYST-512: Restyle, and rename style props on CapsuleTab

Tick what you have done:
[x] I have double checked the functionality with the ticket in linear, or any other relevant discussion avenue
[x] I have created/updated any relevant test code
[x] I have tested it myself

@alimnfl alimnfl requested a review from adamnoto March 13, 2026 08:59
@alimnfl alimnfl self-assigned this Mar 13, 2026
@linear
Copy link

linear bot commented Mar 13, 2026

@netlify
Copy link

netlify bot commented Mar 13, 2026

Deploy Preview for coneto ready!

Name Link
🔨 Latest commit 70c3996
🔍 Latest deploy log https://app.netlify.com/projects/coneto/deploys/69b4e6290f573b0008b19d10
😎 Deploy Preview https://deploy-preview-292--coneto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clicking write tab doesn't work, is the test even passing? it's scary if it does pass... can you report and double check if test passing before working on the fix?

Copy link
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one hasn't been done:

Then add margin-left and margin-right of the tab bar of 5px, currently the tabs are too "mepet" with the outside border.

because the tab still mepet

Image

@alimnfl alimnfl requested a review from adamnoto March 14, 2026 03:02
@alimnfl
Copy link
Contributor Author

alimnfl commented Mar 14, 2026

clicking write tab doesn't work, is the test even passing? it's scary if it does pass... can you report and double check if test passing before working on the fix?

so ya, it's work for now, It will show like this after using onTabChange, but not properly handled on the conditional state, but for now I think it's not error, I've add the condition to onTabChange uses.

@alimnfl
Copy link
Contributor Author

alimnfl commented Mar 14, 2026

I think this one hasn't been done:

Then add margin-left and margin-right of the tab bar of 5px, currently the tabs are too "mepet" with the outside border.

because the tab still mepet

Image

done for this, sorry I miss that...

@alimnfl
Copy link
Contributor Author

alimnfl commented Mar 14, 2026

clicking write tab doesn't work, is the test even passing? it's scary if it does pass... can you report and double check if test passing before working on the fix?

first, for the test it's not have it to move another tab sorry....

but for now it was done to doing that one (move to another tab), with or without onTabChange...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants