Skip to content

[Improvement] SYST-516: Move table loading spinner to top left of the table body#293

Open
alimnfl wants to merge 6 commits intomainfrom
improvement/move-table-loading-top-left-of-the-table-body
Open

[Improvement] SYST-516: Move table loading spinner to top left of the table body#293
alimnfl wants to merge 6 commits intomainfrom
improvement/move-table-loading-top-left-of-the-table-body

Conversation

@alimnfl
Copy link
Contributor

@alimnfl alimnfl commented Mar 13, 2026

Description:
This pull request updates the loading-spinner placement to the first Table.Row level, improving visbility when the table is loading.

Source:
[Improvement] SYST-516: Move table loading spinner to top left of the table body

Tick what you have done:
[x] I have double checked the functionality with the ticket in linear, or any other relevant discussion avenue
[x] I have created/updated any relevant test code
[x] I have tested it myself

@alimnfl alimnfl requested a review from adamnoto March 13, 2026 19:25
@alimnfl alimnfl self-assigned this Mar 13, 2026
@linear
Copy link

linear bot commented Mar 13, 2026

@netlify
Copy link

netlify bot commented Mar 13, 2026

Deploy Preview for coneto ready!

Name Link
🔨 Latest commit e46b421
🔍 Latest deploy log https://app.netlify.com/projects/coneto/deploys/69b4dad14cabb800089da517
😎 Deploy Preview https://deploy-preview-293--coneto.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

…nt/move-table-loading-top-left-of-the-table-body
Copy link
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm... a bit more, it's not top left yet tho, just top but top center...

@alimnfl alimnfl requested a review from adamnoto March 14, 2026 03:25
@alimnfl
Copy link
Contributor Author

alimnfl commented Mar 14, 2026

hm... a bit more, it's not top left yet tho, just top but top center...

done

Copy link
Contributor

@adamnoto adamnoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conflicted. And please take the task description more carefully. I have described what is the top left that's supposed to mean.

@alimnfl
Copy link
Contributor Author

alimnfl commented Mar 14, 2026

Conflicted. And please take the task description more carefully. I have described what is the top left that's supposed to mean.

image

I've ask the placement in the chat actually, and just want to know the placement, because I don't know what's the best placement in your thought

@alimnfl alimnfl requested a review from adamnoto March 14, 2026 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants