mkosi-initrd: protect old initrd image against errors #3589
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
requested changes
Mar 13, 2025
behrmann
reviewed
Mar 13, 2025
There was a problem hiding this comment.
I agree with @DaanDeMeyer on how this should be implemented, but generally I do want to see this feature. I've had the exact thing this is supposed to prevent happen to me with dracut a few times. :)
With this approach we are always invalidating an amount of space equal to the initrd size, but ok, I see your point. |
aafeijoo-suse
force-pushed
the
initrd-backup-and-restore-on-error
branch
2 times, most recently
from
4f690b5 to
c4a23ff
Compare
|
Let's merge #3591 first and then rebase this on top of that and make use of Path more |
aafeijoo-suse
force-pushed
the
initrd-backup-and-restore-on-error
branch
from
c4a23ff to
9c88011
Compare
behrmann
approved these changes
Mar 14, 2025
DaanDeMeyer
reviewed
Mar 14, 2025
When `copy_tree()` ends up calling `cp`, if it fails because there is not enough space, it leaves an incomplete initrd image in the output directory. If we are writing the initrd image directly where a bootloader entry has an initrd configured, the system will fail to boot. So, instead of copying the initrd image directly to the output, copy it next to it in the same output directory, and if the copy is successful, replace it.
aafeijoo-suse
force-pushed
the
initrd-backup-and-restore-on-error
branch
from
9c88011 to
e133298
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
copy_tree()ends up callingcp, if it fails because there is not enough space, it leaves and incomplete initrd image in the output directory. If we are writing the initrd image directly where a bootloader entry has an initrd configured, the system will fail to boot. So, backup the old initrd image before callingcopy_tree(), and restore it if that function throws an exception.