Various postmarketos fixes #3913
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grub cannot be installed on postmarketos yet so don't try to make the default image bios bootable.
We try to not touch the rootfs directory in setup() at all, so set up merged /usr in install() instead like we do for debian. Additionally, we also make sync() does not touch the rootfs either by having it operate on a temporary directory instead of the real rootfs.
Use similar variable names as we use elsewhere instead of the verbose variable names that stick out like a sore thumb.
Half of the commands in createrepo() are run without a sandbox at the moment, let's fix that. This also contains various coding style fixes.
behrmann
approved these changes
Sep 24, 2025
craftyguy
reviewed
Sep 24, 2025
|
BTW, no integration tests for postmarketos yet? |
I already found out the alpine linux-virt package is missing required kernel modules so it's going to take a while before we can get those working. |
I sent a patch to add this dependency: https://gitlab.postmarketos.org/postmarketOS/pmaports/-/merge_requests/7079 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.