Assorted regex fixes #3914
Merged
Assorted regex fixes #3914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Python regexes like strings are unicode meaning that they match anything unicode consides, e.g. a number in the case of \d, which is more than the usually expected [0-9]. Tighten this in the places where these classes are used for better readability. Also reorder the character classes for KERNEL_VERSION_PATTERN and the systemd-stub version to be the same order for clarity and escape the dash in the latter, since the need to escape a dash in a character range is position dependent.
Currently we only read uppercase variables starting with a letter, but shell variables only restriction is not starting with a number, so lowercase names and names starting with an underscore are allowed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
re.ASCIIin places where we use backslash character classes (\dor\w), so that arbitrary unicode numbers and letters are not accepted, where we might not expect them.Also the character classes accepted for variable names in
read_env_filesis widened to what shells allow, so that we can guarantee roundtripping files read with it.