-
Notifications
You must be signed in to change notification settings - Fork 384
mkosi-initrd: add 89-ethernet.network for network profile #3917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why not to enable default network config option? |
Sorry what do you mean by that precisely? |
I mean, why not to enable -Ddefault-network=true meson option? Or, do I misunderstand the point of this PR? |
@yuwata That would have to be done in Fedora, where we obviously cannot make that change for backwards compat concerns |
Ahh, I forgot configs in mkosi repository does not build systemd but use systemd provided by distribution. Sorry for the noise. |
a447659
to
f053dfd
Compare
f053dfd
to
dc08938
Compare
@@ -0,0 +1 @@ | |||
89-ethernet.network.example No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think bookworm is a target for this, but the file changed its name in commit 9b7a624267fddc5c20bd15480e7a393d7a3b270e from 80-
to 89-
, so there might be the unlikely case where this produces a dangling symlink (pre 255).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty sure most things here won't work with 255, so a danglign symlink is the least problem
b57ae03
to
3e479bb
Compare
Looking at the CI failure, there is a certain problem: The thing coming in is a traversable, since the thing in resources need not be backed by a filesystem, the package could be whatever weird thing. I'm not sure that e.g. Python wheels support symlinks (they're zipfiles that have to work on windows). While that might not be relevant when running mkosi from source, this will break zipapps or possibly distro packages where building a wheel might be an intermediate step. A workaround might actually be to ship the |
Python used to be fun, you could assign a banana to a bathtub and it would just do it |
Well, you can still do that, but now we just get warned before trying to take a bath in the banana. :) |
In the context of the initrd profile the simpler workaround might even be to duplicate the file contents here, at the same time sidestepping the renaming issue mentioned above. |
3e479bb
to
87f9512
Compare
That means we don't get updates, I prefer the symlink |
mkosi/resources/mkosi-initrd/mkosi.profiles/network/mkosi.postinst
Outdated
Show resolved
Hide resolved
87f9512
to
4598740
Compare
mkosi/resources/mkosi-initrd/mkosi.profiles/network/mkosi.postinst
Outdated
Show resolved
Hide resolved
networkd ships with no configuration enabled, so we need to symlink one in for it to do anything
4598740
to
f45825c
Compare
networkd ships with no configuration enabled, so we need to symlink one in for it to do anything