Skip to content

Conversation

bluca
Copy link
Member

@bluca bluca commented Sep 26, 2025

networkd ships with no configuration enabled, so we need to symlink one in for it to do anything

@yuwata
Copy link
Member

yuwata commented Sep 26, 2025

Why not to enable default network config option?

@bluca
Copy link
Member Author

bluca commented Sep 26, 2025

Sorry what do you mean by that precisely?

@yuwata
Copy link
Member

yuwata commented Sep 26, 2025

I mean, why not to enable -Ddefault-network=true meson option? Or, do I misunderstand the point of this PR?

@DaanDeMeyer
Copy link
Contributor

@yuwata That would have to be done in Fedora, where we obviously cannot make that change for backwards compat concerns

@yuwata
Copy link
Member

yuwata commented Sep 26, 2025

Ahh, I forgot configs in mkosi repository does not build systemd but use systemd provided by distribution. Sorry for the noise.

@@ -0,0 +1 @@
89-ethernet.network.example No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think bookworm is a target for this, but the file changed its name in commit 9b7a624267fddc5c20bd15480e7a393d7a3b270e from 80- to 89-, so there might be the unlikely case where this produces a dangling symlink (pre 255).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure most things here won't work with 255, so a danglign symlink is the least problem

@bluca bluca force-pushed the networkd-initrd branch 2 times, most recently from b57ae03 to 3e479bb Compare September 26, 2025 13:21
@behrmann
Copy link
Contributor

behrmann commented Sep 26, 2025

Looking at the CI failure, there is a certain problem: The thing coming in is a traversable, since the thing in resources need not be backed by a filesystem, the package could be whatever weird thing. I'm not sure that e.g. Python wheels support symlinks (they're zipfiles that have to work on windows). While that might not be relevant when running mkosi from source, this will break zipapps or possibly distro packages where building a wheel might be an intermediate step.

A workaround might actually be to ship the mkosi.extra as a tar file, which can be adressed as a single file as a resouce.

@bluca
Copy link
Member Author

bluca commented Sep 26, 2025

Python used to be fun, you could assign a banana to a bathtub and it would just do it

@behrmann
Copy link
Contributor

Well, you can still do that, but now we just get warned before trying to take a bath in the banana. :)

@behrmann
Copy link
Contributor

In the context of the initrd profile the simpler workaround might even be to duplicate the file contents here, at the same time sidestepping the renaming issue mentioned above.

@DaanDeMeyer
Copy link
Contributor

That means we don't get updates, I prefer the symlink

networkd ships with no configuration enabled, so we need to symlink
one in for it to do anything
@bluca bluca merged commit 1d167c0 into systemd:main Sep 26, 2025
32 of 40 checks passed
@bluca bluca deleted the networkd-initrd branch September 26, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants