Make sure apt sources are installed when BaseTrees= is in the mix #3963
+95
−48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaanDeMeyer
force-pushed
the
fix-apt-sources
branch
2 times, most recently
from
e252508 to
3be9878
Compare
Let's make sure to install apt sources every time we install the apt package, even if BaseTrees= or volatile packages or such are in the mix. To make this work we unfortunately have to reintroduce install_packages(). While we're at it, make sure the installed apt sources don't use the configured mirror or snapshot. We only install a default set of sources and for anything custom users should install their own sources.
DaanDeMeyer
force-pushed
the
fix-apt-sources
branch
from
3be9878 to
c12fe5c
Compare
behrmann
reviewed
Oct 16, 2025
| def repositories(cls, context: Context, for_image: bool = False) -> Iterable[AptRepository]: | ||
| mirror = None if for_image else context.config.mirror | ||
| if not mirror: | ||
| mirror = "http://http.kali.org/kali" |
There was a problem hiding this comment.
That should be mentioned in the man page in the table for default mirrors (it should have been there before, but I just noticed).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let's make sure to install apt sources every time we install the apt package, even if BaseTrees= or volatile packages or such are in the mix.
To make this work we unfortunately have to reintroduce install_packages().
While we're at it, make sure the installed apt sources don't use the configured mirror or snapshot. We only install a default set of sources and for anything custom users should install their own sources.