Various small fixes #4119
Open
Various small fixes #4119
+15
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
‣ Validating certificates and keys cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted cp: setting attribute 'security.ima' for 'security.ima': Operation not permitted ‣ "cp --recursive --no-dereference --preserve=mode,links,timestamps,ownership,xattr --reflink=auto --copy-contents /work/usr/share/crypto-policies/back-ends/DEFAULT /work/home/elmarco/.cache/mkosi/mkosi-workspace-5c6zgtv2/sandbox/etc/crypto-policies/back-ends --no-target-directory" returned non-zero exit code 1.
‣ An EFI bootable image with systemd-boot was requested but a systemd-boot binary was not found at /usr/lib/systemd/boot/efi This is required to provide /usr/lib/systemd/boot/efi/systemd-bootx64.efi
Dead since commit 634b0ef.
behrmann
reviewed
Jan 13, 2026
Comment on lines
+102
to
+104
| return any( | ||
| "security.ima" in os.listxattr(p, follow_symlinks=False) for p in (path, *path.rglob("*")) | ||
| ) |
Contributor
There was a problem hiding this comment.
ruff complains
Suggested change
| return any( | |
| "security.ima" in os.listxattr(p, follow_symlinks=False) for p in (path, *path.rglob("*")) | |
| ) | |
| return any("security.ima" in os.listxattr(p, follow_symlinks=False) for p in (path, *path.rglob("*"))) |
Author
There was a problem hiding this comment.
c&p from tree_has_selinux_xattr. We may want to generalize the function instead.
Contributor
There was a problem hiding this comment.
Ruff complains here because security.ima is shorter than security.selinux and therefore this fits on a single line. Either way, this needs to be addressed.
Comment on lines
+133
to
+134
| if tree_has_ima_xattr(src): | ||
| with_xattrs = False |
Contributor
There was a problem hiding this comment.
This seems problematic, since even if we decided to e.g. copy xattr to keep selinux attributes around, we'd drop them if a file also has these xattrs.
Despite being a bit annoying is there any issue with the warning from cp?
Contributor
There was a problem hiding this comment.
Ok, but since this is the same as security.selinux then, shouldn't it be be
statfs(os.fspath(dst.parent)) != OVERLAYFS_SUPER_MAGIC
or (not tree_has_selinux_xattr(src) and not tree_has_ima_xattr(src))then?
daandemeyer
reviewed
Jan 13, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.