qemu: fall back to TCP host forwarding when vsock is unavailable#4212
Open
gourryinverse wants to merge 1 commit intosystemd:mainfrom
Open
qemu: fall back to TCP host forwarding when vsock is unavailable#4212gourryinverse wants to merge 1 commit intosystemd:mainfrom
gourryinverse wants to merge 1 commit intosystemd:mainfrom
Conversation
gourryinverse
force-pushed
the
mkosi_ssh
branch
2 times, most recently
from
a96e540 to
39145a1
Compare
When vsock is not available (VSock=no or no /dev/vsock), dynamically
allocate a host port and configure QEMU user-mode networking with
hostfwd to forward SSH traffic over TCP loopback.
Changes:
- finalize_state() and register_machine() accept explicit proxy_command
and ssh_address parameters, falling back to vsock defaults when a CID
is present
- Dynamic port allocation via socket.bind(("127.0.0.1", 0)) avoids
collisions when multiple VMs run concurrently
- Use socat TCP4 (not TCP) to avoid AI_ADDRCONFIG getaddrinfo failures
inside the mkosi bubblewrap sandbox.
- Update run_ssh() hint to no longer require Vsock=yes
Signed-off-by: Gregory Price <gourry@gourry.net>
gourryinverse
force-pushed
the
mkosi_ssh
branch
from
39145a1 to
183068b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When vsock is not available (VSock=no or no /dev/vsock), dynamically allocate a host port and configure QEMU user-mode networking with hostfwd to forward SSH traffic over TCP loopback.
Changes:
when paired with: systemd/systemd#41013 -- this allows for ssh machine/* syntax