feat: added confirmation prompt to mkosi burn before burning image to device#4275
feat: added confirmation prompt to mkosi burn before burning image to device#4275estebanpuyanas wants to merge 3 commits intosystemd:mainfrom
Conversation
… device the confirmation prompt runs lsblk to retreive device information and then requests the user types y or yes to proceed and n or no to abort. If the user chooses to proceed, it will continue the burning process as usual, otherwise it prints a message saying the burning process was aborted
behrmann
left a comment
behrmann
left a comment
There was a problem hiding this comment.
This functionality should have gone into repart, as mentioned in the issue, though I'm not sure whether that is still the case with the installer work that's ongoing. I think that would still make more sense.
That being said, a few comments
|
I'm somewhat of two minds about this. This operation already requires elevated privileges, and none of the other commands usually used to get images onto devices ( I'm ±0 on this, but I see that there are people who legitimately want to be on the safe side here. If it's not to go into repart, maybe an |
…R review 1. Changed reply to use input 2. Registered --interactive in config.py and wrapped the confirmation prompt process to only run when --interactive=true 3. Added relevant tests in test_config.py and updated test_json.py to include interactive arg Co-authored by Claude Code Sonnet 4.6 <noreply@anthropic.com>
2 participants
Explanation:
The confirmation prompt runs
lsblkto retrieve device information and then requests the user typesyoryesto proceed andnornoto abort. If the user chooses to proceed, it will continue the burning process as usual, otherwise it prints a message saying the burning process was aborted.Closes #3821