Refactor mailcrypt creation #767
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y3n4
force-pushed
the
refactor-mailcrypt-creation
branch
6 times, most recently
from
482ae5e to
920f794
Compare
y3n4
force-pushed
the
refactor-mailcrypt-creation
branch
from
37f02cf to
ab0829c
Compare
|
| } | ||
|
|
||
| public function onSecurityInteractiveLogin(InteractiveLoginEvent $event): void | ||
| { | ||
| $user = $event->getAuthenticationToken()->getUser(); | ||
|
|
||
| if ($user instanceof User) { | ||
| $this->handleLogin($user); | ||
| $password = $event->getRequest()->get('_password'); |
There was a problem hiding this comment.
Is this guaranteed to work on all interactive logins? I don't know the details of this InteractiveLoginEvent and when exactly it is dispatched. Is login via the login form the only interactive login scenario? I guess there _password is accessible in the request.
There was a problem hiding this comment.
Theoretically InteractiveLoginEvent covers anything which is interactive, including Json login. But with our current code, the login form is the only case, yes
https://symfony.com/doc/current/security.html#other-events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.