Skip to content

fix(audio): reap owned server on client shutdown - #10

Merged
enkerewpo merged 1 commit into
syswonder:mainfrom
Origamii520:agent/persistent-audio-server-lifecycle-rebased
Aug 5, 2026
Merged

fix(audio): reap owned server on client shutdown#10
enkerewpo merged 1 commit into
syswonder:mainfrom
Origamii520:agent/persistent-audio-server-lifecycle-rebased

Conversation

@Origamii520

Copy link
Copy Markdown
Contributor

Replacement for #7 after rebasing the focused feature onto the rewritten current main history, as requested by the maintainer.

This change always stops and reaps the client-owned audio device server during application shutdown, closes its log handle, preserves externally owned servers, and still performs server cleanup if reverse-bridge shutdown raises.

Validation:

  • 40 repository Python unittest cases passed in the existing project environment
  • 4 focused audio lifecycle behavior checks passed
  • commit authorship check passed
  • git diff --check passed

No frontend files changed, so the frontend bundle is unchanged. Maintainers retain branch modification permission.

Always stop and reap the client-owned audio device server, close its log handle, preserve external servers, and run cleanup even when the reverse bridge stop path fails.

Assisted-by: Codex:gpt-5.6-sol [TOOL Codex]
@Origamii520

Copy link
Copy Markdown
Contributor Author

已按你的说明基于重写后的当前 main 重新提交,且只保留原 #7 的单一功能改动;本地测试与身份检查均已通过。烦请 @enkerewpo 审核。

@Origamii520

Copy link
Copy Markdown
Contributor Author

补充:两个工作流当前均为 action_required,尚未创建任何 job,需要仓库维护者先批准该 fork PR 的 Actions 运行;本地验证与提交身份检查已完成。烦请 @enkerewpo 一并批准 CI 后审核。

@enkerewpo enkerewpo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enkerewpo
enkerewpo merged commit 28947ab into syswonder:main Aug 5, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants