fix(vitals): load Soma URDF mesh assets - #11
Merged
enkerewpo merged 1 commit intoAug 9, 2026
Conversation
Assisted-by: Codex:gpt-5
enkerewpo
self-requested a review
August 6, 2026 07:10
enkerewpo
approved these changes
Aug 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The Vitals client could receive URDF text from Soma, but its local wire schema
did not include attached URDF assets. Relative mesh references therefore had no
browser-accessible base URL, causing mesh-based robot models to render without
their visual geometry.
Changes
UrdfAsset,include_assets, andassetswire fields.Validation
.venv/bin/python -m unittest discover -s tests -v— 41 passed..venv/bin/python -m unittest tests.test_vitals_transport tests.test_urdf_assets -v— 21 passed..venv/bin/python -m pip check— passed.npm ci— passed with no vulnerabilities.npm run build— passed; committed bundle remained unchanged.npm run test:visual— 16 passed.python3 scripts/check_commit_authorship.py --base upstream/main --head HEAD— passed.Compatibility
The protobuf changes are additive. Older Soma deployments that return no
assets continue to load the URDF with an empty asset base URL. No database or
configuration migration is required.
Related change