Skip to content

feat(executor): add result verification framework - #242

Open
KouweiLee wants to merge 3 commits into
syswonder:devfrom
KouweiLee:validation
Open

feat(executor): add result verification framework#242
KouweiLee wants to merge 3 commits into
syswonder:devfrom
KouweiLee:validation

Conversation

@KouweiLee

@KouweiLee KouweiLee commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add the common robonix/service/verifier/verify capability contract with call_id and opaque args_json
  • add Executor-owned verification rules with exact provider matching before contract fallback
  • verify successful sync and async capability results before publishing the single terminal RTDL event
  • fail closed on rejected, unavailable, malformed, or timed-out verifier responses
  • share the immutable verification policy across parallel plan branches with Arc

Follow-up work

  • implement SceneVerifier under services/verifiers/
  • implement VlmVerifier under services/verifiers/
  • stabilize verifier-specific args_json conventions after both implementations exist
  • add deployment verification rules and verifier-backed Webots and ranger-car end-to-end scenarios

… scripts

Updated the submodule reference in the documentation to the latest commit. Enhanced the Webots deployment scripts by enforcing the use of the `rmw_zenoh_cpp` implementation to ensure compatibility across the simulator and its providers. Improved the startup script to wait for live sensor data, and added a timeout for state reporting in the lifecycle management to prevent blocking. Additionally, refined the topic specification building process to skip known kinds during reconciliation.
@github-actions github-actions Bot added type:feature New feature (feat:) comp:executor system/executor comp:scene system/scene comp:api pylib/robonix-api comp:capabilities capabilities/ contracts comp:docs docs/ and READMEs and removed type:feature New feature (feat:) labels Sep 2, 2026
@github-actions github-actions Bot added the type:feature New feature (feat:) label Sep 2, 2026
@KouweiLee

KouweiLee commented Sep 2, 2026

Copy link
Copy Markdown
Contributor Author

Implementation split / next steps:

  1. This PR provides the shared Verify contract and Executor-owned verification pipeline only.
  2. Add SceneVerifier under services/verifiers/ and define its verifier_args parsing. @1mujue
  3. Add VlmVerifier under services/verifiers/, including explicit camera provider selection. @KouweiLee
  4. After both implementations stabilize, tighten the args_json convention and add verifier-backed Webots and ranger-car end-to-end coverage.

@KouweiLee
KouweiLee marked this pull request as draft September 2, 2026 03:37
@1mujue
1mujue marked this pull request as ready for review September 2, 2026 11:13

@1mujue 1mujue left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commits follow the code conduct of Robonix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:api pylib/robonix-api comp:capabilities capabilities/ contracts comp:docs docs/ and READMEs comp:executor system/executor comp:scene system/scene type:feature New feature (feat:)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants