Change content handling to use byte buffer instead of parsing chunks directly#299
Merged
Conversation
Refactor content handling to use BytesMut to avoid splitting multi-bytes UTF-8 across two chunks.
Refactor content handling to use a buffer to prevent UTF-8 parsing error.
Owner
|
Thanks @ybalbert ! Can you provide an example string to test this with? |
Contributor
Author
|
Sure, here's the pasta (expires in 6 days) I used for testing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to prevent an error that a multi-bytes UTF-8 character gets split across multiple chunks and fails to decode. The error could happen when pasting a long paragraph without whitespace in language like Chinese:
Tested by building a local docker image. The error doesn't happen any more on the same content.