Add conditional exports to package.json #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UziTech
requested changes
Mar 6, 2025
package.json
Outdated
| "exports": { | ||
| "import": "./dist/signature_pad.js", | ||
| "require": "./dist/signature_pad.umd.js", | ||
| "default": "./dist/signature_pad.umd.js", |
There was a problem hiding this comment.
Looks like it has a problem with the trailing comma in this line
lukescott
commented
Mar 13, 2025
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
## [5.0.5](v5.0.4...v5.0.5) (2025-03-14) ### Bug Fixes * Add conditional exports to package.json ([#815](#815)) ([005a090](005a090))
|
🎉 This PR is included in version 5.0.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm in the process of updating to Node 22 and I ran into an issue with the default export not working:
This PR fixes compatibility with TypeScript's
"nodenext"module resolution. The"module"property is non-standard and not supported by node. The official way is "Conditional Exports":https://nodejs.org/docs/latest-v22.x/api/packages.html#conditional-exports
This is needed for packages that support CommonJS and ESM where the
"type"is omitted or set to"commonjs".(Note: "require" could be omitted, but I was more explicit including both "require" and "default")